fix: header alg value in examples #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas.J.Han <[email protected]>
lukasjhan
requested review from
zustkeeper,
berendsliedrecht and
cre8
as code owners
|
@lukasjhan Just a suggestion: instead of using the string, we could instead reference: https://github.com/lukasjhan/sd-jwt-js/blob/fix/example-header-alg/packages/node-crypto/src/crypto.ts#L31 with |
cre8
approved these changes
Oct 16, 2024
|
Oh, that's a great idea. I almost forgot. I'll update the pr 😀. Thank you |
Signed-off-by: Lukas.J.Han <[email protected]>
cre8
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #250.
NOTE: This bug only affects examples. There is no effect on other library code.