Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add clone ojbect logic in unpackObj #181

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

lukasjhan
Copy link
Member

the old UnpackObj function changes the input object. So I changed with clone logic and make old unpackObj rename to unpackObjInternal.

NOTE

  • unpackArray function is not exported anymore.

It closes #163

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (b0f6a1b) to head (4647a56).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   98.02%   98.01%   -0.01%     
==========================================
  Files          23       23              
  Lines        2074     2068       -6     
  Branches      307      309       +2     
==========================================
- Hits         2033     2027       -6     
  Misses         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cre8 cre8 merged commit 2e92cb3 into openwallet-foundation:main Mar 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of features in decode, present package change the input object.
2 participants