Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base64url convention #179

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

lukasjhan
Copy link
Member

@lukasjhan lukasjhan commented Mar 15, 2024

I updated convention of base64url related functions.
This will be a breaking changes on @sd-jwt/utils. Maybe applied PEX but It's not merged yet, So It will be fine.

It will close #178

Signed-off-by: Lukas.J.Han <[email protected]>
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (fec88f0) to head (244c831).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files          23       23           
  Lines        2074     2074           
  Branches      307      307           
=======================================
  Hits         2033     2033           
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cre8 cre8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
i would not frame it as breaking change, since we just changed the naming

@cre8 cre8 merged commit f8db275 into openwallet-foundation:main Mar 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the util/base64 function names to start with lowercase
2 participants