-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update present example #142
Merged
cre8
merged 3 commits into
openwallet-foundation:next
from
lukasjhan:feat/update-present-example
Mar 8, 2024
Merged
feat: update present example #142
cre8
merged 3 commits into
openwallet-foundation:next
from
lukasjhan:feat/update-present-example
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
lukasjhan
requested review from
zustkeeper,
berendsliedrecht and
cre8
as code owners
March 7, 2024 15:07
lukasjhan
commented
Mar 7, 2024
lukasjhan
commented
Mar 7, 2024
lukasjhan
commented
Mar 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #142 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 23 23
Lines 1983 1983
Branches 284 284
=======================================
Hits 1938 1938
Misses 45 45 ☔ View full report in Codecov by Sentry. |
cre8
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cre8
pushed a commit
to cre8/sd-jwt-js
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
cre8
pushed a commit
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
cre8
pushed a commit
to cre8/sd-jwt-js
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #138, I updated docs and examples for presentationFrame.
And fix some minor typos :)