From d7a9a9eb624fa64564ce016a138e527cd059f38b Mon Sep 17 00:00:00 2001 From: Mike Pattrick Date: Tue, 27 Aug 2024 12:01:43 -0400 Subject: [PATCH] userspace: Correctly set ip offload flag in native tunneling. Coverity identified the following issue CID 425094: (#1 of 1): Unchecked return value (CHECKED_RETURN) 4. check_return: Calling dp_packet_hwol_tx_ip_csum without checking return value (as is done elsewhere 9 out of 11 times). This appears to be a true positive, the fields getter was called instead of its setter. Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") Reported-by: Eelco Chaudron Acked-by: Simon Horman Signed-off-by: Mike Pattrick Signed-off-by: Eelco Chaudron --- lib/netdev-native-tnl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c index 16c56608d87..529d64fe1d9 100644 --- a/lib/netdev-native-tnl.c +++ b/lib/netdev-native-tnl.c @@ -254,7 +254,7 @@ dp_packet_tnl_ol_process(struct dp_packet *packet, if (IP_VER(ip->ip_ihl_ver) == 4) { dp_packet_hwol_set_tx_ipv4(packet); - dp_packet_hwol_tx_ip_csum(packet); + dp_packet_hwol_set_tx_ip_csum(packet); } else if (IP_VER(ip->ip_ihl_ver) == 6) { dp_packet_hwol_set_tx_ipv6(packet); }