From d9491a244eadcea4ec34e86640234f533ea41f08 Mon Sep 17 00:00:00 2001 From: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Date: Sun, 5 Jan 2025 18:03:20 -0800 Subject: [PATCH] fix: features --- .github/workflows/benchmark-call.yml | 2 +- .github/workflows/benchmarks.yml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/benchmark-call.yml b/.github/workflows/benchmark-call.yml index 036f84fd1..6d15a8078 100644 --- a/.github/workflows/benchmark-call.yml +++ b/.github/workflows/benchmark-call.yml @@ -148,7 +148,7 @@ jobs: - name: "Feature flags: memory allocator" run: | ALLOCATOR=${{ inputs.memory_allocator || github.event.inputs.memory_allocator }} - echo "FEATURE_FLAGS=${FEATURE_FLAGS},$ALLOCATOR" >> $GITHUB_ENV + echo "FEATURE_FLAGS=$ALLOCATOR,${FEATURE_FLAGS}" >> $GITHUB_ENV - name: "Feature flags: aggregation" if: contains(github.event.pull_request.labels.*.name, 'run-benchmark') || (github.event_name == 'push' && github.ref == 'refs/heads/main') run: | diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 121fa9b5b..c8784c8a8 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -132,6 +132,7 @@ jobs: internal_log_blowup: ${{ matrix.benchmark_run.internal_log_blowup }} max_segment_length: ${{ matrix.benchmark_run.max_segment_length }} e2e_bench: ${{ matrix.benchmark_run.e2e_bench }} + features: ${{ matrix.benchmark_run.features }} secrets: inherit summarize: