Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero seed #766

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Fix zero seed #766

merged 3 commits into from
Dec 8, 2022

Conversation

tanemaki
Copy link
Contributor

@tanemaki tanemaki commented Dec 7, 2022

Description

  • This pull request changes the behavior when the random number seed is set to 0.
  • In the current implementation, when the config.project.seed is set to 0, the seed value is not fixed to zero but randomized. After merging this pull request, when the config.project.seed is set to 0, the seed value is set to 0.
  • A seed can be randomized by either removing the seed key from the YAML file or using None as the seed value (null in the YAML file).
  • A warning message is generated when the seed value of 0 is used.
  • Fixes [Bug]: Tricky behavior when config.project.seed is set to 0 #763.

It would be great to get feedback on my warning message because I am not a native English speaker.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@jpcbertoldo
Copy link
Contributor

thanks a lot for this PR 🙏 🙌

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this!

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit 2cc43a7 into openvinotoolkit:main Dec 8, 2022
@tanemaki tanemaki deleted the fix-zero-seed branch December 8, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tricky behavior when config.project.seed is set to 0
5 participants