Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Fix torchmetrics version #754

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Dec 1, 2022
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. So forcing a more recent version of torchmetrics would break pytorch 1.8 compatibility?

@ashwinvaidya17
Copy link
Collaborator Author

ashwinvaidya17 commented Dec 1, 2022

Thanks. So forcing a more recent version of torchmetrics would break pytorch 1.8 compatibility?

It works with pytorch 1.8 but there are some development efforts required from our side to support the new torchmetrics API. I've kept the original issue open so we can revisit it again.

@ashwinvaidya17 ashwinvaidya17 merged commit b6755c4 into main Dec 1, 2022
@ashwinvaidya17 ashwinvaidya17 deleted the ashwin/torchmetrics_version branch December 1, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: __new__() missing 1 required positional argument: 'task'
2 participants