Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor data modules #558
Refactor data modules #558
Changes from 10 commits
ee1cfce
ec5199e
9f0a35e
dea176f
62a04f8
e91afad
df4a805
c225a83
ac0dc8a
5d90209
c1e6724
2d70d89
f5f17db
f02065f
9cba9da
5b3e841
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[minor]
val
andtest
are assumed to be each other in a confusing way(1)
X_batch_size
withX \in {train, test}
, andtest_batch_size
is used both fortest
andval
DataLoader(2)
transform_config_Y
withY in {train, val}
, andtransform_config_val
is used both fortest
andval
AnomalibDataseti.e.
batch size: config is available for
test
and assumed fortest
andval
transform: config is available for
val
and assumed fortest
andval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[minor] Is there a reason for assuming this?
It could make sense that
transform_config_train
could have "weak" data augmentations (e.g. tiny brightness changes) but that should not be repeated in the validation set.if this is to be kept, a warning wouldn't be harmful :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.