Bump up pytorch-lightning version to 1.6.0 or higher
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fix/sa/pytorch-lightning-vulnerability
…o fix/sa/pytorch-lightning-vulnerability
…o fix/sa/pytorch-lightning-vulnerability
slows down the training.
…github.com:openvinotoolkit/anomalib into fix/sa/pytorch-lightning-vulnerability
…o fix/sa/pytorch-lightning-vulnerability
…lly set `trainer.global_step`
…y set `trainer.global_step`
…lly set `trainer.global_step`
…tically set `trainer.global_step`
djdameln
reviewed
Apr 8, 2022
| @@ -68,7 +69,7 @@ def _add_images( | |||
| for log_to in module.hparams.project.log_images_to: | |||
| if log_to in loggers.AVAILABLE_LOGGERS: | |||
| # check if logger object is same as the requested object | |||
| if log_to in logger_type and module.logger is not None: | |||
| if log_to in logger_type and module.logger is not None and isinstance(module.logger, ImageLoggerBase): | |||
There was a problem hiding this comment.
Can you explain why this is needed?
There was a problem hiding this comment.
it is to silence mypy. Some typings have changed in pl 1.6, causing some mypy issues.
There was a problem hiding this comment.
Alright, so no functional changes to the visualizer callback then
djdameln
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current version of pytorch_lightning library has vulnerability to code injection (code read from environment variables started with PL_ could be evaluated.)
Fixes Fix the pytorch_lightning env vars vulnerability #191
Changes
Checklist