-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/data/btad #120
Feature/data/btad #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I only have one minor comment.
+ "/ground_truth/" | ||
+ samples.label | ||
+ "/" | ||
+ samples.image_path.str.rstrip("bmp").str.rstrip(".") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use with_suffix
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could try, but probably wouldn't work. It's becuse this line changes the entire column. And, as far as I know, only str manipulation is possible with this approch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Note
It's important to note that furter refactoring could be possible to abstract, but this would be done after all the datasets of interest are added to the repo.
Changes
Checklist