Unable to set context header for jaeger

[ssorathia]

I seem to be having an issue setting a custom header for the propagation of the traceid.

I have a config like the following:

load_module modules/ngx_http_opentracing_module.so;
load_module modules/ngx_http_jaeger_module.so;

events {
  worker_connections  1024;  ## Default: 1024
}

http {
   opentracing on;
   jaeger_trace_context_header_name custom-trace-id;
   jaeger_service_name nginx;
   jaeger_sampler_type const;
   jaeger_sampler_param 1;

   server {
      location /dump {
         proxy_pass http://localhost:8080;
      }
   }
}

However, when I issue a simple curl command against this endpoint, curl localhost/dump, the downstream service that gets proxied to still sees the Uber-Trace-Id header and my custom trace header is nowhere to be found. I'm not sure if I'm doing something wrong, or if I'm not understanding what that configuration parameter is really supposed to do. I'm using the latest docker container at rnburn/nginx-opentracing:latest to run this.

Any help on this would be appreciated.

[rnburn]

Could you try adding proxy_pass_request_headers on;?

[ssorathia]

I believe that is the default for that option, but I gave it a try and I see the same behavior.

[rnburn]

@isaachier - any idea what's going on here?

[isaachier]

Ya I think I just fixed this. See jaegertracing/jaeger-client-cpp#91.

[rnburn]

@ssorathia - that fix hasn't been released yet, but try rebuilding the docker image with these arguments:

docker build --build-arg JAEGER_CPP_VERSION=master -t nginx-opentracing .

[isaachier]

Ya very sorry I didn't see this bug until recently.

[ssorathia]

Ok, let me give it a try, I'll get back to you shortly.

[ssorathia]

That looks like it resolved the issue! The header seems to both be used for new trace's as well as if a trace id is passed in via the new header. From my perspective, this is the expected behavior.

Thanks for the quick fixes, I can use what I have right now, but just wondering as to when you think this will be rolled into a release?

[isaachier]

Hopefully I'll push a release within the next few days. If @rnburn is ready, a corresponding change here can be merged immediately afterwards.

[ssorathia]

That would be awesome! I'll keep an eye out for it. Do you guys want to close this issue, want me to close it, or what is your process for these types of issues?

[rnburn]

Fixed in 0.4.0 docker image.