Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double encoded signatures hex + base64 #26

Open
strantalis opened this issue Sep 18, 2023 · 0 comments
Open

double encoded signatures hex + base64 #26

strantalis opened this issue Sep 18, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@strantalis
Copy link
Member

In the current opentdf implementations for c++ and javascript it seems like we are double encoding the signatures. The spec for the root signature and policy binding it only mentions base64 wrapped hmac signature.

rootSignature.sig String The signature for the entire payload. \n\nExample of signature generation:\nBase64.encode(HMAC(BinaryOfAllHashesCombined, payloadKey))
policyBinding Object This contains a keyed hash that will provide cryptographic integrity on the policy object, such that it cannot be modified or copied to another TDF, without invalidating the binding. Specifically, you would have to have access to the key in order to overwrite the policy.This is Base64 encoding of HMAC(POLICY,KEY)

In my opinion the spec either needs to be updated or those clients need to adhere to what the spec says.

@strantalis strantalis added the bug Something isn't working label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant