Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix php_url_encode_hash_ex call for 8.3 #328

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

remicollet
Copy link
Contributor

From UPGRADING.INTERNALS

   - The PHPAPI php_url_encode_hash_ex() function has had its signature change
     from:
     PHPAPI void php_url_encode_hash_ex(HashTable *ht, smart_str *formstr,
                                const char *num_prefix, size_t num_prefix_len,
                                const char *key_prefix, size_t key_prefix_len,
                                const char *key_suffix, size_t key_suffix_len,
                                zval *type, const char *arg_sep, int enc_type);
     to:
     PHPAPI void php_url_encode_hash_ex(HashTable *ht, smart_str *formstr,
                                const char *num_prefix, size_t num_prefix_len,
                                const zend_string *key_prefix,
                                zval *type, const zend_string *arg_sep, int enc_type);
     The change to use zend_string prevent the computation of the arg_sep
     length at each call. The key_suffix parameter was dropped as it was a
     constant value and depended on the key_prefix parameter to not be NULL.

@doubaokun doubaokun merged commit 50ef36d into openswoole:master Nov 4, 2023
9 of 14 checks passed
@remicollet remicollet deleted the issue-83 branch November 5, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants