Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hideOnDidAccept set default true #2981

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix: hideOnDidAccept set default true #2981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/quick-open/src/browser/quick-input-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ export class QuickInputService implements IQuickInputService {

const result = new Deferred<string | undefined>();
const validateInput = options && options.validateInput;
// 兼容旧逻辑
if (options.hideOnDidAccept === undefined) {
options.hideOnDidAccept = true;
}

const inputBox = this.injector.get(InputBoxImpl, [options]);
this.inputBox = inputBox;
Expand Down