Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling / night mode #51

Closed
irgendwie opened this issue Mar 19, 2017 · 8 comments · Fixed by #736
Closed

Scheduling / night mode #51

irgendwie opened this issue Mar 19, 2017 · 8 comments · Fixed by #736

Comments

@irgendwie
Copy link

As already suggested ages ago by someone (stylish-userstyles/stylish#242), I would love to have a night mode option, which automatically turns websites dark at specific hours.

It could work by selecting specific styles, which one wants to have automatically activated at a configurable time frame.

Since I mainly use Stylus for that reason (apart from a few very good light themes) this feature would be perfect! 😊

@Sylk
Copy link

Sylk commented Mar 21, 2017

I like the option of supporting this. We could open up users to defining time period where certain themes are active. I think that's the most valid way to go about this.

@JonnyRedHed
Copy link

JonnyRedHed commented Mar 23, 2017

This is a good idea. Maybe take a cue to two from the add-on below.

At the moment the best instant one size fits all add-on is 'Care your Eyes'

The night mode works well when your just visiting some random site.

@schomery
Copy link
Contributor

schomery commented Apr 5, 2017

We could open up users to defining time period where certain themes are active.

To me, to support this we need two new permissions, "idle" and "alarms". The second one can be skipped by using window.setTimeout perhaps, still the first one is mandatory to handle machine's idle state changes to reset timers and apply new states. I can work on this but since manage.html is the target, I guess there will be major conflicts with @tophf work on #50.

@tophf
Copy link
Member

tophf commented Apr 5, 2017

I guess there will be major conflicts with @tophf work on #50.

Actually, major conflicts will be almost everywhere until we handle that PR.

@schomery
Copy link
Contributor

schomery commented May 3, 2017

guys I am working on this scheduling thing on https://github.com/schomery/stylish-chrome/tree/scheduler

Please give it a try and let me know if it works fine or not.

@tophf
Copy link
Member

tophf commented May 3, 2017

@schomery, it'd be more convenient to discuss it if you open a PR.

@schomery
Copy link
Contributor

schomery commented May 3, 2017

done; #62

@eight04
Copy link
Collaborator

eight04 commented Jun 26, 2019

You may want to test this branch: #736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants