Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch vagrant to use Debian 12 #5158

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

tomhughes
Copy link
Member

Similar to #5157 this switches the vagrant configuration to use Debian 12 instead of Ubuntu.

Only tested with the libvirt provider at the moment.

@nenad-vujicic
Copy link
Contributor

Wouldn't be safer to stick to specific Debian version (e.g. 12.7) instead of using the latest v12? Similarly for #5157

@tomhughes
Copy link
Member Author

I don't know enough about Debian to be able to answer that but the minor versions are just updated installers that include the latest updates aren't they?

@tomhughes
Copy link
Member Author

As far as I can tell there aren't any images for specific releases anyway - the list just contains one image for each major version which looks like it is regularly updated with the latest packages.

@mmd-osm
Copy link
Contributor

mmd-osm commented Sep 7, 2024

Test completed with status "ok" on VirtualBox 6.1 w/ virtualbox provider:

Finished in 449.210410s, 4.0671 runs/s, 2230.1976 assertions/s.
1827 runs, 1001828 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for Minitest, Minitest-0, Minitest-1 to /srv/openstreetmap-website/coverage. 6287 / 6679 LOC (94.13%) covered.
Lcov style coverage report generated for Minitest, Minitest-0, Minitest-1 to coverage/lcov.info

@gravitystorm
Copy link
Collaborator

Needs rebasing, since it conflicts with the change in image to jammy that was merged as part of #5070

@gravitystorm gravitystorm added the changes requested Changes are needed before the PR will be merged or reviewed again label Nov 13, 2024
@tomhughes
Copy link
Member Author

Rebased now.

@tomhughes tomhughes removed the changes requested Changes are needed before the PR will be merged or reviewed again label Nov 13, 2024
@gravitystorm gravitystorm merged commit a64b723 into openstreetmap:master Nov 13, 2024
22 checks passed
@gravitystorm
Copy link
Collaborator

Merged, thanks!

@tomhughes tomhughes deleted the vagrant-debian branch November 13, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants