Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2 login flow returns error 500 #5400

Closed
HarelM opened this issue Dec 16, 2024 · 7 comments · Fixed by #5406
Closed

OAuth2 login flow returns error 500 #5400

HarelM opened this issue Dec 16, 2024 · 7 comments · Fixed by #5406

Comments

@HarelM
Copy link

HarelM commented Dec 16, 2024

URL

Https://israelhiking.osm.org.il

How to reproduce the issue?

This is a standard login flow from a third party app:

  1. Go to israelhiking.osm.org.il
  2. Click the sad face after the intro screen to login
  3. Enter osm credentials where needed
  4. Approve the scope
  5. See the error

Screenshot(s) or anything else?

Screenshot_20241216_081736_Chrome

I think this is relatively new, maybe after the outage yesterday, but it might existed even before.

@tordans
Copy link
Contributor

tordans commented Dec 16, 2024

We are seeing the same issue.

OSM is in Readonly-Mode https://en.osm.town/@osm_tech/113656639378201391 but since I can log into the website, the readonly has to be only for certain parts of the website. I assumed the Rails parts would work but the editing part wouldn't. But then again commenting on notes is also prohibited so maybe only the user sessions are "allowed" since those can be deleted when switching back to Amsterdam as primary (or maybe they are not stored in the DB at all)…

@tomhughes
Copy link
Member

Creating new OAuth logins requires creating records in the oauth tables in the database. Existing tokens should work fine I think but you won't be able to create new ones.

@tordans
Copy link
Contributor

tordans commented Dec 16, 2024

@tomhughes Thanks. Is there capacity to improve the handing of this error case by showing the "we are in readonly" message in step 1 of the oAuth process so users don't run into the uncaught 500?

@BDVGitHub
Copy link

BDVGitHub commented Dec 16, 2024

I think it has to do with the following:
The OpenStreetMap database cannot be modified at the moment due to maintenance work being carried out.
Saw this message when opening OpenStreetMap

Does anyone know how long this maintenance work will last?

@HolgerJeromin
Copy link
Contributor

Does anyone know how long this maintenance work will last?

https://community.openstreetmap.org/t/openstreetmap-org-currently-offline-operations-team-are-working-to-restore-15-december-2024/122930

@HarelM
Copy link
Author

HarelM commented Dec 16, 2024

Thanks for the link @HolgerJeromin! I thought that the fact that I can see the openstreetmap.org site means the failure was resolved, but I now learned that it's in read-only mode.
I'll wait patiently for the resolution.
Thanks for all the hard work around OSM, it is very much appreciated! Keep it up.

@gravitystorm
Copy link
Collaborator

I should clarify here that this issue is "fixed" in that #5406 means the site now won't return a 500 error for the OAuth login flow.

The read-only status on www.osm.org is still ongoing, and is a matter for the OSMF OWG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants