-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When a user posts a story in their diary, give them the option to share with social media #1391
Comments
It's open source, so you can work on any issues you want to. This one is probably a reasonably good starter issue because it's a small front-end change, and it's unlikely anyone else is working on it. |
I wouldn't say it was small myself. I mean it won't need that much code but it will presumably mean dragging in some third party component(s) and hence making a choice about which is best to use. There will also be significant privacy issues to deal with. By all means do have a go at it - nobody else is as far as I know - but I wouldn't say it's trivial. |
I don't see significant privacy issues, maybe we're imagining different implementations? For the twitter case it'd be a link like There probably is some third-party component that URL formation for common social media networks |
Well that's the ultra low tech approach for twitter sure, but I think a more normal approach would be to use one of the gems I'm sure exists that adds some sort of sharing panel for a range of sites - the important thing would be to ensure that it didn't load anything from the sites until you chose to use it. |
That's just a warning that can be ignored - I'll figure out how to get rid of it at some point! |
Hey @tomhughes, @pnorman, @gravitystorm I added the gem I do not see that file in the
|
Probably best to put it in screen-ltr.css and screen-rtl.css although you might want to consider only loading it on those pages that need it rather than loading it site wide. |
Side Note Regarding This Issue:I've attempted to use the following gems for implementing social media sharing functionality: While the A few questions arise from these attempts:
Thank you for your guidance! |
Well neither of those has been maintained recently - in the case of That in turn speaks to the lack of support for more recent networks and possibly also to why any installation instructions no longer work. My inclination would definitely be to look to see if there are newer and/or better supported alternatives. |
It does look like There's a bit of javascript client side but basically all it does is react to a button click by doing |
I'm currently working on implementing the social media sharing functionality, and everything is progressing well.
|
Just a note for anyone reviewing the old history of this issue, it appears that comments were made by a deleted user. There are replies to comments that no longer exist. |
Mostly done in #4985. It's not exactly "When a user posts a story in their diary" because posting redirects you to a list of diary entries that doesn't have share buttons. You have to open the posted entry again to see the buttons. Maybe the redirect should be altered. If you think so, open another issue. |
Give them the option to share with Twitter, Facebook, Instagram, Jabber (XMPP) etc.
The text was updated successfully, but these errors were encountered: