diff --git a/app/controllers/diary_entries_controller.rb b/app/controllers/diary_entries_controller.rb index ff6dfc826c..760c9a3012 100644 --- a/app/controllers/diary_entries_controller.rb +++ b/app/controllers/diary_entries_controller.rb @@ -71,6 +71,7 @@ def show if @entry @title = t ".title", :user => params[:display_name], :title => @entry.title @opengraph_properties = { + "og:title" => @entry.title, "og:image" => @entry.body.image, "og:image:alt" => @entry.body.image_alt, "og:description" => @entry.body.description, diff --git a/app/helpers/open_graph_helper.rb b/app/helpers/open_graph_helper.rb index cde848e5d1..a496268e49 100644 --- a/app/helpers/open_graph_helper.rb +++ b/app/helpers/open_graph_helper.rb @@ -4,7 +4,7 @@ module OpenGraphHelper def opengraph_tags(title, properties) tags = { "og:site_name" => t("layouts.project_name.title"), - "og:title" => title || t("layouts.project_name.title"), + "og:title" => properties["og:title"] || title || t("layouts.project_name.title"), "og:type" => "website", "og:url" => url_for(:only_path => false), "og:description" => properties["og:description"] || t("layouts.intro_text") diff --git a/test/controllers/diary_entries_controller_test.rb b/test/controllers/diary_entries_controller_test.rb index aad759b5b6..7d543250bc 100644 --- a/test/controllers/diary_entries_controller_test.rb +++ b/test/controllers/diary_entries_controller_test.rb @@ -648,6 +648,17 @@ def test_show_hidden_comments end end + def test_show_og_title + user = create(:user) + diary_entry = create(:diary_entry, :user => user, :title => "The Important Blog Post") + + get diary_entry_path(user, diary_entry) + assert_response :success + assert_dom "head meta[property='og:title']" do + assert_dom "> @content", "The Important Blog Post" + end + end + def test_show_og_image_with_no_image user = create(:user) diary_entry = create(:diary_entry, :user => user, :body => "nothing")