Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a road preset should remove construction=* #8877

Closed
boothym opened this issue Jan 4, 2022 · 3 comments
Closed

Selecting a road preset should remove construction=* #8877

boothym opened this issue Jan 4, 2022 · 3 comments
Labels
preset An issue with an OpenStreetMap preset or tag

Comments

@boothym
Copy link
Contributor

boothym commented Jan 4, 2022

If you come across road which is tagged highway=construction + construction=residential and you want to mark it as open - the easiest way to do this to use the residential road preset rather than editing the raw tags.

However this leaves behind the construction=* tag - which is not needed and can be problematic for some routers. So iD should remove this as well - since it already removes access=no if that is also tagged.

@tyrasd
Copy link
Member

tyrasd commented May 12, 2022

@tyrasd tyrasd closed this as completed May 12, 2022
@boothym
Copy link
Contributor Author

boothym commented Jun 10, 2022

Thanks for sorting this.

I said above that "since it already removes access=no if that is also tagged." - but having found a road with highway=construction + construction=residential + access=no, it turns out that selecting the residential preset only removes the construction tag and still leaves access=no on the way.

Can this be fixed so that access=no is removed as well?

@tyrasd
Copy link
Member

tyrasd commented Jun 14, 2022

This was actually changed on purpose (see openstreetmap/id-tagging-schema#416 (comment) and openstreetmap/id-tagging-schema#443). I think it is reasonable to expect mappers to check and if needed adjust the values of the access field after changing a road back from the construction preset. Similar to how values of other tags should be checked whether they have changed (e.g. surface, maxspeed, lit, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants