Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic mouse horizontal scroll doesn't start a map pan #7659

Closed
quincylvania opened this issue Jun 4, 2020 · 4 comments
Closed

Magic mouse horizontal scroll doesn't start a map pan #7659

quincylvania opened this issue Jun 4, 2020 · 4 comments
Assignees
Labels
usability An issue with ease-of-use or design
Milestone

Comments

@quincylvania
Copy link
Collaborator

Scrolling vertically with a magic mouse on macOS properly starts to pan the map, and from there you can scroll-to-pan in any direction. However, the same does not work as expected when starting to scroll horizontally. Previously a horizontal scroll could start browser page navigation, but since fixing #5552 it just does nothing.

@quincylvania quincylvania added the usability An issue with ease-of-use or design label Jun 4, 2020
@quincylvania quincylvania added this to the 2.18.0 milestone Jun 4, 2020
@quincylvania quincylvania self-assigned this Jun 4, 2020
@quincylvania
Copy link
Collaborator Author

quincylvania commented Jun 4, 2020

Turns out this was caused by iD ignoring scroll events without a vertical component, because historically these would not affect the map's transform. It now appears to work correctly.

I don't think this addresses #7134, since iD tries to treat events from physical scroll wheels differently than gesture scroll events, but I don't have a mouse with a horizontal scroll wheel so I can't test it.

@1ec5
Copy link
Collaborator

1ec5 commented Jun 6, 2020

I don't have a mouse with a horizontal scroll wheel so I can't test it.

How about a trackpad where you scrub the bottom edge to scroll horizontally? Would it be interpreted the same way as a mouse with a horizontal scroll wheel?

@quincylvania
Copy link
Collaborator Author

How about a trackpad where you scrub the bottom edge to scroll horizontally? Would it be interpreted the same way as a mouse with a horizontal scroll wheel?

@1ec5 Not sure, I'm not familiar with this interaction… I have a MacBook.

@1ec5
Copy link
Collaborator

1ec5 commented Jun 8, 2020

Yeah, I’m thinking of Windows laptops mainly. I’ve previously owned Dell and Toshiba laptops with this sort of scrolling before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

2 participants