Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator: Suggest "add gate" if highway crosses barrier #6349

Open
tordans opened this issue May 11, 2019 · 5 comments
Open

Validator: Suggest "add gate" if highway crosses barrier #6349

tordans opened this issue May 11, 2019 · 5 comments
Labels
considering Not Actionable - still considering if this is something we want validation An issue with the validation or Q/A code

Comments

@tordans
Copy link
Collaborator

tordans commented May 11, 2019

Same as when a highway crosses another highway, if it crosses a barrier, we want to specify how that happens. IMO most of the time, via a gate. Which could be the one-click-solution.

What are other common node values for such crossings?

Also, the gate that the validator creates could also copy the access keys from the highway. So if the highway access is private, the gate has the same access. At least this is how I always thought the access should be done; I could be double-tagging?

Bildschirmfoto 2019-05-11 um 15 36 16

Example: https://www.openstreetmap.org/node/6466534074

@bhousel bhousel added considering Not Actionable - still considering if this is something we want validation An issue with the validation or Q/A code labels May 12, 2019
@quincylvania
Copy link
Collaborator

The validation makes sense, I think we should do it.

@westnordost
Copy link
Contributor

@tordans there is not only the barrier=gate though, but other types of barrier-entrances as well.

@BjornRasmussen
Copy link
Contributor

Perhaps an add barrier suggestion, but not quick fix, could be shown

@tordans
Copy link
Collaborator Author

tordans commented May 18, 2019

Maybe, this needs to be a bit more defined:

  • When a street (way) crosses a barrier=fence (way),
    1. suggest "Add node" (without value if no node was present)
    2. suggest "Specify how the street crosses the fence, eg. gate, lift_gate, entrance" (without a quickfix, just the text)
    3. suggest autofix barrier=gate (node)
  • Where a street (way) crosses a barrier=hedge (way),
    1. suggest "Add node" (as above)
    2. suggest text only (as above)
    3. suggest autofix barrier=entrance (node)
  • If …

Is there a way to see the combinations (and usage stats) of barrier-nodes on the crossing of highway+barrier=fence,hedge,wall,…?

https://taginfo.openstreetmap.org/keys/barrier#values only shows, that barrier=gate is by far the most used of the "opening" keys. But it does not help with stats like we need for the above(?).

@1ec5
Copy link
Collaborator

1ec5 commented May 20, 2019

It’s important to tag access on barrier nodes when it differs from the way. (You might be allowed to use the driveway on either side of the fence, but the fence itself may be locked – you have to find your way around it.)

By default, OSRM treats these barrier tags as being traversable in the absence of any access tag for driving directions. For walking directions, all barriers are traversable except for these tags; for cycling directions, all are traversable except for these tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not Actionable - still considering if this is something we want validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

6 participants