Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New validation rule: no cuisine=vegetarian/vegan #5993

Closed
nicolasmaia opened this issue Feb 27, 2019 · 5 comments
Closed

New validation rule: no cuisine=vegetarian/vegan #5993

nicolasmaia opened this issue Feb 27, 2019 · 5 comments
Assignees
Labels
validation An issue with the validation or Q/A code
Milestone

Comments

@nicolasmaia
Copy link

In the same vein as #5580, to avoid a deprecated tag scheme.

@matkoniecz
Copy link
Contributor

It probably should not be assumed that cuisine=vegetarian is diet:vegetarian=only, it probably may also be diet:vegetarian=yes.

Is there way already to offer two upgrade paths in iD validator?

@quincylvania
Copy link
Collaborator

Is there way already to offer two upgrade paths in iD validator?

Not at the moment. I've considered this but I think it's nicer to have a single Upgrade button.

@quincylvania quincylvania self-assigned this Feb 28, 2019
@quincylvania quincylvania added the validation An issue with the validation or Q/A code label Feb 28, 2019
@quincylvania quincylvania added this to the Next Release milestone Feb 28, 2019
@matkoniecz
Copy link
Contributor

Note that changing cuisine=vegan to diet:vegan=yes may be incorrect, where it should be diet:vegan=only.

"I think it's nicer to have a single Upgrade button." is OK but in that case validation rules that require it should not be introduced.

@quincylvania
Copy link
Collaborator

On the contrary, diet:vegan=yes would always be correct while diet:vegan=only would only sometimes be "more correct". We don't know if the original tagger would have meant only or yes anyway so we should go with the less restrictive option.

@matkoniecz
Copy link
Contributor

But it means that while (AFAIK) people used diet:vegan=yes to mark "vegan food is available, but nonvegan is also available" now it mean "vegan food is available, nonvegan - who knows".

Though admit that it is not an ideal tagging scheme:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

3 participants