Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace happen dependency with d3.selection#dispatch? #4654

Open
bhousel opened this issue Jan 4, 2018 · 0 comments
Open

Replace happen dependency with d3.selection#dispatch? #4654

bhousel opened this issue Jan 4, 2018 · 0 comments
Labels
chore-dependency Improvements to one of iD's dependencies

Comments

@bhousel
Copy link
Member

bhousel commented Jan 4, 2018 •
edited
Loading

We use happen to test browser events, but it uses a deprecated method of creating events that limits what we can test (see #4618 (comment)).

We could probably accomplish the same thing with d3.selection#dispatch, which I believe was added to D3 more recently than when @tmcw built happen for this purpose.
@bhousel bhousel added the chore-dependency Improvements to one of iD's dependencies label Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore-dependency Improvements to one of iD's dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhousel