Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is sculptor not sculpter #4504

Merged
merged 1 commit into from
Nov 4, 2017
Merged

Conversation

simonpoole
Copy link
Contributor

I believe this is a fairly clear typo in the presets

@bhousel
Copy link
Member

bhousel commented Nov 4, 2017

Thanks @simonpoole good catch!
I'm surprised it has been this way for so long.

Looks like there are 291 of craft=sculpter to be cleaned up..
https://taginfo.openstreetmap.org/search?q=craft%3Dsculpter

We should wait until the next iD release and then after the fix goes live, I'll change them.

@bhousel bhousel merged commit 40d71e5 into openstreetmap:master Nov 4, 2017
@abdeldjalil09
Copy link
Contributor

abdeldjalil09 commented Nov 5, 2017

and also this tag : "craft=sweep" it should be "chimney_sweeper"

@simonpoole
Copy link
Contributor Author

simonpoole commented Nov 5, 2017

@abdeldjalil09 sweep is IMHO a legit short form, seems as if the change to chimney_sweeper was the usual wiki fiddling.

@abdeldjalil09
Copy link
Contributor

@bhousel
Copy link
Member

bhousel commented Nov 5, 2017

see https://wiki.openstreetmap.org/wiki/Tag:craft%3Dchimney_sweeper

Thanks @abdeldjalil09 I did not know that the tag had changed back in 2014 based on a brief discussion on the tagging@ list. Please open a new issue.

@simonpoole
Copy link
Contributor Author

In any case it is a wonderful example of, even if completely well intentioned, you shouldn't change tags without really good reasons. And if you do, just changing the wiki is not enough.

@abdeldjalil09
Copy link
Contributor

abdeldjalil09 commented Nov 7, 2017

Please open a new issue.

I'm going to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants