Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenStreetCam Support! #4499

Merged
merged 12 commits into from
Nov 7, 2017
Merged

OpenStreetCam Support! #4499

merged 12 commits into from
Nov 7, 2017

Conversation

bhousel
Copy link
Member

@bhousel bhousel commented Nov 3, 2017

This PR adds support for OpenStreetCam to iD 🎉

It works pretty ok right now, but I'll improve a few things:

  • change the marker style to be distinct from Mapillary
  • add attribution / link to openstreetcam.org
  • add username
  • add date captured
  • add some viewer controls? (forward/back.. maybe rotate image?)

screenshot 2017-11-03 16 47 51

cc @mvexel

@bhousel
Copy link
Member Author

bhousel commented Nov 6, 2017

Going with greenish for Mapillary, bluish for OpenStreetcam:

High Zoom:
screenshot 2017-11-05 22 19 39

Low Zoom:
screenshot 2017-11-05 22 21 31

@bhousel
Copy link
Member Author

bhousel commented Nov 6, 2017

I hacked together some viewer controls this morning.. Rotate buttons work and will apply the rotation for all images on that sequence. TODO: forward/back buttons, then merging 👍

viewer-controls

This was referenced Nov 7, 2017
@bhousel bhousel merged commit d686766 into master Nov 7, 2017
@mvexel
Copy link
Contributor

mvexel commented Nov 8, 2017

Belated 🎉🌋!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants