Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab-Button does not jump to the right spot after a tag is added #4494

Closed
rebio opened this issue Nov 1, 2017 · 8 comments
Closed

Tab-Button does not jump to the right spot after a tag is added #4494

rebio opened this issue Nov 1, 2017 · 8 comments
Labels
usability An issue with ease-of-use or design

Comments

@rebio
Copy link

rebio commented Nov 1, 2017

A pretty weird bug that I yet don't know how to exactly reproduce.

I edit a way/node/area and type in any key and press Tab to go to the tag. I enter the tag and press tab again to go to the next key. Instead of saving the tag and going to the new key field it does delete the inserted tag and jumps right to the tags field of the new key.

bug example

In the image above you see what it looks like. I created the area, wanted to insert area=yes. I entered "area", pressed tab. It jumped to the tag. I inserted "yes" and pressed tab again so that it jumps to the next key. On screen you can see the current cursor position.

@bhousel
Copy link
Member

bhousel commented Nov 1, 2017

Thanks for reporting @rebio - do you see this issue on http://preview.ideditor.com/master/ ?
It looks similar to #4424, which was fixed already.

@bhousel bhousel added the waitfor-info Waiting for more info label Nov 1, 2017
@rebio
Copy link
Author

rebio commented Nov 1, 2017

I can test it with the tip version. However, I have no idea when or why the bug occurs.

It is not bound to an area or the area=yes tag though. I got the same bug while adding information to nodes and ways and also more than one way (so not a specific one, but random ways) a few times today. Since it's not a bug that appears once every full moon, I should get it sooner than later.

@1ec5
Copy link
Collaborator

1ec5 commented Nov 1, 2017

Thanks for reporting this issue! I've been reproducing this issue in Firefox on the Mac for years, but it comes and goes from month to month for me, and I'm not sure whether it's iD's fault or Firefox's. I've gotten used to avoiding the Tab key in favor of clicking in the margin beside the textbox, which can be pretty inconvenient.

@bhousel
Copy link
Member

bhousel commented Nov 6, 2017

If this is intermittent, I wonder if it's related to a slow network connection fetching autocomplete values from taginfo and then trying to focus on the wrong field.. Like #2876

@rebio
Copy link
Author

rebio commented Nov 6, 2017

I had this problem on various PCs with different internet connections (range from 2-125 MBit). So it is possible that it is related to the speed, but I don't think so.
I may thought that iD is stumbles over too fast editing (so you write faster than iD can search for the terms and you just press tab before iD can list the suggestions)

I have done a few edits with the latest builds now. I noticed that they are painfully slow, but I have not seen this bug so far. But since the bug appeared out of nowhere I'm not sure if it's really gone for good.

@rebio
Copy link
Author

rebio commented Nov 14, 2017

I'm just editing with 2.5.0 and the bug still exists.
I wanted to add addr:street, pressed TAB. then Ctrl + V to insert the street name, then TAB again. And I got the bug as described above.

@bhousel bhousel added usability An issue with ease-of-use or design and removed waitfor-info Waiting for more info labels Nov 14, 2017
@boothym
Copy link
Contributor

boothym commented Dec 18, 2017

I've also encountered this bug, and it's present on the master version. It is intermittent, but I've found it can occur on points, lines and areas; on any row of the tag list; and it doesn't matter if a tag value is suggested or not.

If you want to try and reproduce it: draw an area, select natural > wetland preset. Click the + below all tags, type in "wet" and press tab. Type in "ti" so tidalflat appears then press tab. It should go to the second box on the third line.

@1ec5
Copy link
Collaborator

1ec5 commented Apr 25, 2018

Reverse-duplicate of #4991, which is now fixed. 🎉

@1ec5 1ec5 closed this as completed Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

4 participants