Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4489 add missing office presets #4491

Merged

Conversation

Nmargolis
Copy link
Contributor

@Nmargolis Nmargolis commented Oct 31, 2017

Adds association, advertising_agency, and surveyor office presets as requested in #4489.

This is my first time contributing, so I'm very open to feedback!!

I also noticed there were several other presets missing that are on the OSM Wiki (see below). Should those be added as part of a separate issue?

Here are the other ones on the OSM Wiki:

  • adoption_agency
  • charity
  • energy_supplier
  • forestry
  • foundation
  • guide
  • logistics
  • moving_company
  • notary
  • private_investigator
  • quango
  • religion
  • tax
  • tax_advisor
  • travel_agent
  • water_utility

@abdeldjalil09
Copy link
Contributor

@bhousel
Copy link
Member

bhousel commented Oct 31, 2017

Looks great @Nmargolis! You can add the other ones on the list to this PR also, and we'll merge them all together.

There are a few cases where I would probably change the names to be a bit more recognizable to a US-English speaker, but overall it's ok. (e.g. "Association" I would call a "Nonprofit Organization Office")

- adoption_agency
- charity
- energy_supplier
- forestry
- foundation
- tax
- guide
- moving_company
- notary
- private_investigator
- quango
- surveyor
- tax_advisor
- water_utility
@bhousel
Copy link
Member

bhousel commented Oct 31, 2017

Wow that was fast, thanks @Nmargolis .. Is this ready to merge?

@bhousel
Copy link
Member

bhousel commented Oct 31, 2017

Looks great @Nmargolis , thanks for your first contribution!! 🙌

@bhousel bhousel merged commit 28889dd into openstreetmap:master Oct 31, 2017
@Nmargolis
Copy link
Contributor Author

thanks @bhousel! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants