Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tourism=chalet and add search terms #4490

Closed
lakedistrictOSM opened this issue Oct 30, 2017 · 3 comments
Closed

Rename tourism=chalet and add search terms #4490

lakedistrictOSM opened this issue Oct 30, 2017 · 3 comments
Labels
preset An issue with an OpenStreetMap preset or tag

Comments

@lakedistrictOSM
Copy link

Currently the name for this tag in iD is Chalet, however (confusingly) this tag is not for tagging chalets as in wooden buildings/cabins but holiday cottages as detailed on the wiki page.

For tourism=chalet I suggest the following:

  • name: Holiday Cottage
  • search terms: holiday cottage, holiday home, vacation home, chalet
    (chalet moved to terms because some users will be used to searching "chalet" when mapping a holiday cottage)
@bhousel
Copy link
Member

bhousel commented Oct 30, 2017

Sounds fine, @lakedistrictOSM - Because there is some confusion about the word, can you just confirm that the tag really is used to tag holiday cottages and not cabins?

The osm wiki is often wrong, or just one person's opinion of what they think the tag should mean. (In other words, I don't want to just change this label just because the osm wiki says so).

@bhousel bhousel added the waitfor Waiting for something label Oct 30, 2017
@lakedistrictOSM
Copy link
Author

Of course the wiki is often wrong, but I believe it is correct in this instance.

I've had a look at the iD/blob/master/dist/locales files and the German language version of iD uses the name "Ferienhaus" which literally translates to "holidayhouse" and the French version uses "Gîte" which translates to "holiday home" or "tourist cottage".

I agree it would be good to get more opinions on this before the any changes are made to the name.

@bhousel bhousel added preset An issue with an OpenStreetMap preset or tag and removed waitfor Waiting for something labels Oct 31, 2017
@bhousel
Copy link
Member

bhousel commented Oct 31, 2017

Thanks for looking into it @lakedistrictOSM - I just made the change..
(I didn't add "chalet" to the search terms because it is automatically included because it is the tag value)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

2 participants