Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't disable spellchecking for Changeset Comments #4471

Closed
jidanni opened this issue Oct 26, 2017 · 4 comments
Closed

Don't disable spellchecking for Changeset Comments #4471

jidanni opened this issue Oct 26, 2017 · 4 comments
Labels
usability An issue with ease-of-use or design

Comments

@jidanni
Copy link
Contributor

jidanni commented Oct 26, 2017

When entering a Changeset Comment, the user finds the browser's spellchecker has been disabled.
No matter Firefox or Chromium.

But spellchecking when filling in Profile Description on https://www.openstreetmap.org/user/<ME>/account works fine, So it must be an id problem.

@bhousel bhousel added the usability An issue with ease-of-use or design label Oct 26, 2017
@bhousel
Copy link
Member

bhousel commented Oct 26, 2017

You are right, spellcheck is disabled. I guess we could turn spellcheck back on for just the comment field..

Here are some attributes that we set on all of the <input> fields in iD. (added to fix #3839)

iD/modules/util/util.js

Lines 257 to 263 in 9c6c82d

export function utilNoAuto(selection) {
return selection
.attr('autocomplete', 'off')
.attr('autocorrect', 'off')
.attr('autocapitalize', 'off')
.attr('spellcheck', 'false');
}

@pnorman
Copy link
Contributor

pnorman commented Oct 27, 2017

I'd turn on spellcheck for changeset comment, and object name, note, and fixme.
I recommend keeping the auto* stuff off for name, particularly autocapitalize.

@bhousel bhousel closed this as completed in 672a555 Nov 1, 2017
@bhousel
Copy link
Member

bhousel commented Nov 1, 2017

I ended up just turning spellcheck back on for all the textarea type fields (see list)

@jidanni
Copy link
Contributor Author

jidanni commented Nov 3, 2017

Good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

3 participants