Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine playground preset terminology #4415

Merged
merged 3 commits into from
Oct 9, 2017
Merged

Conversation

1ec5
Copy link
Collaborator

@1ec5 1ec5 commented Oct 8, 2017

A couple improvements to playground presets:

  • Renamed the “Springy Rocker” preset to “Spring Rider” and added “spring rocker” as a synonym. Both “spring rider” and “spring rocker” appear to be more common than “springy rocker” in usage online.
  • Added “merry-go-round” as a synonym for “Play Roundabout”.

@1ec5 1ec5 changed the title Rename Springy Rocker preset to Spring Rider Refined playground preset terminology Oct 8, 2017
@1ec5 1ec5 changed the title Refined playground preset terminology Refine playground preset terminology Oct 8, 2017
Copy link
Member

@bhousel bhousel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ec5 , you updated the generated dist/locales/en.json file - can you instead update the source .json files:

  • data/presets/presets/playground/rocker.json
  • data/presets/presets/playground/roundabout.json

then npm run build (this will overwrite en.json)

@1ec5
Copy link
Collaborator Author

1ec5 commented Oct 9, 2017

Thanks, I updated those two JSON files. Running npm run-script build produced tons of changes, enough to crash FileMerge. 😬 So I only added the relevant changes to en.json.

@bhousel
Copy link
Member

bhousel commented Oct 9, 2017

Thanks @1ec5!

@bhousel bhousel merged commit 114903f into openstreetmap:master Oct 9, 2017
@1ec5 1ec5 deleted the patch-2 branch October 9, 2017 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants