Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write "Local GPX" in imagery_used changeset tag if that's not true #4385

Closed
jidanni opened this issue Oct 2, 2017 · 2 comments
Closed
Labels
help wanted For intermediate contributors, requires investigation or knowledge of iD code

Comments

@jidanni
Copy link
Contributor

jidanni commented Oct 2, 2017

Some trace ids should be recorded in changesets
openstreetmap/openstreetmap-website#1645 (comment)

@bhousel bhousel added good first issue Best for first-time contributors. No experience necessary! Hacktoberfest labels Oct 2, 2017
@bhousel bhousel changed the title Some trace ids should be recorded in changesets Don't write "Local GPX" in imagery_used changeset tag if that's not true Oct 2, 2017
@bhousel
Copy link
Member

bhousel commented Oct 2, 2017

Right now the imagery_used tag always says "Local GPX", but instead it should probably write the name of the file.

This is because:

  • it might not be local (i.e. passed in via url api)
  • it might not even be a gpx, as we allow other types like .geojson and .kml now.

The code that does this is here:

var gpx = context.layers().layer('gpx');
if (gpx && gpx.enabled() && gpx.hasGpx()) {
imageryUsed.push('Local GPX');
}

So, a better thing to do would be to add an accessor to that gpx layer, so this code can call something like gpx.getFilename().

@bhousel bhousel added help wanted For intermediate contributors, requires investigation or knowledge of iD code and removed good first issue Best for first-time contributors. No experience necessary! labels Oct 12, 2017
@jidanni
Copy link
Contributor Author

jidanni commented Feb 12, 2018

I will tell GitHub, that when a
"This was referenced on Nov 11, 2017" is added to a bug,
they really should notify all people subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted For intermediate contributors, requires investigation or knowledge of iD code
Projects
None yet
Development

No branches or pull requests

2 participants