-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't depend on 2 lodashes #4378
Comments
@bhousel? I can help if you agree to this. |
I'd really prefer not to need to transpile the build scripts or introduce a babel dependency. These scripts really don't use much lodash at all, so it should be possible to replace whatever they do with traditional ES5 features. |
@bhousel I worked on the issue today. I was able to set up However, many of the tests that run in PhantomJS depend on the original lodash ( |
@DzikowskiW good question... Those functions seem like ones we could do without.. If you submit a PR to deal with the build scripts, I'll eliminate lodash from the tests. |
This was done! Going forward, no lodash in tests, plz thx. All the tests should run in all of iD's supported browsers - Automated testing currently runs in PhantomJS 2.1 - which is conveniently about the same level of oldness as IE11. 😭 This means:
|
Perhaps you can replace phantomjs with |
followup from #4372 (comment)
We use
lodash
(CommonJS) in a few of our build scripts, but we now uselodash-es
(ES6) in the main iD code. It seems dumb to install lodash twice, so we have 2 options:require
the es6lodash-es
library from a node script.@std/esm
may offer some way forward but I couldn't get it to work after playing with it for an hour or so. It's only released a few weeks ago, so we should wait and see if it improves.The text was updated successfully, but these errors were encountered: