Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding healthcare presets #4329

Merged
merged 9 commits into from
Sep 13, 2017
Merged

Adding healthcare presets #4329

merged 9 commits into from
Sep 13, 2017

Conversation

JamesKingdom
Copy link
Collaborator

Still needs work, closes #3589

@JamesKingdom JamesKingdom added the wip Work in progress label Sep 8, 2017
@bhousel bhousel merged commit 1c95948 into master Sep 13, 2017
@bhousel
Copy link
Member

bhousel commented Sep 13, 2017

Thanks @JamesKingdom for starting this! I cleaned up the healthcare:speciality=* field, and added a few more of the provider types found on the OSM healthcare=* wiki page and just merged this. 👍

@bhousel bhousel deleted the hcpresets branch September 13, 2017 21:04
@bhousel bhousel removed the wip Work in progress label Sep 13, 2017
Copy link

@maraf24 maraf24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not "Specialities"? Isn't the correct plural form for BrE?

@bhousel
Copy link
Member

bhousel commented Nov 14, 2017

Why not "Specialities"? Isn't the correct plural form for BrE?

@maraf24, the tag is healthcare:speciality, but we display "Specialities" on the screen and allow the user to pick multiple values. (This field combines the multiple values together into a single value with semicolons).

screenshot 2017-11-14 08 30 04

@maraf24
Copy link

maraf24 commented Nov 14, 2017

Well, that's why I nit-picking: the spelling as seen on the screenshot is American - "Specialties", not "Specialities" :)

@bhousel
Copy link
Member

bhousel commented Nov 14, 2017

Well, that's why I nit-picking: the spelling as seen on the screenshot is American - "Specialties", not "Specialities" :)

Oh ok - we have an en-GB localization of iD, so the best place to make the change is on Transifex:
https://www.transifex.com/openstreetmap/id-editor/translate/#en_GB/presets/102484336?q=specialt

I'll just change this now, since I want to make a bugfix release this week to fix a few OpenStreetCam and Mapillary things. If you find any other places where iD doesn't look properly British, please go into Transifex and fix it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Presets for Healthcare
3 participants