Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong presets for areas #4319

Closed
4 of 7 tasks
hikemaniac opened this issue Sep 7, 2017 · 5 comments
Closed
4 of 7 tasks

Wrong presets for areas #4319

hikemaniac opened this issue Sep 7, 2017 · 5 comments
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag

Comments

@hikemaniac
Copy link
Contributor

hikemaniac commented Sep 7, 2017

When I was mapping an area, iD suggested the preset "footway" even though the OSM wiki page of the tag clearly points out that it shouldn't be used on polygons. When I checked on some other tags I found out that iD has also got area presets for more tags that shouldn't be applied on polygons

Is it the wiki that is outdated or are there wrong presets in iD?

@bhousel
Copy link
Member

bhousel commented Sep 7, 2017

Thanks for the report - I reformatted your comment to be a list.
It looks like from the wiki that toll booth and cave entrance can be mapped as areas, all the rest of them probably should have area geometry removed.

@bhousel bhousel added good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag labels Sep 7, 2017
@hikemaniac
Copy link
Contributor Author

Oh yeah, it seems like I mixed up natural=cave_entrance. I'm not so sure about barrier=toll_booth though. The "How to map"-section says nothing about areas and it doesn't really make sense to me, because both renderers and routing engines will interpret this tag as a barrier where a fee is collected around the mapped area. Well, I think we should leave it as is until the problem is solved in the wiki.

@bhousel
Copy link
Member

bhousel commented Sep 7, 2017

FWIW, I do see toll booths regularly mapped as areas: http://www.openstreetmap.org/way/56054320

barrier is an interesting key because it can really be used for linear ways or for areas - in the above example it's an area because it has the building=yes tag.

@hikemaniac
Copy link
Contributor Author

OK, that makes sense. Thank you! 😊👍

@bhousel
Copy link
Member

bhousel commented Sep 9, 2017

Closing here, thanks @willemarcel . 👍

@hikemaniac I saw you added leisure=bird_hide to the list, but I think in this case the wiki is wrong. It says not to map as an area, but shows a picture of a shed, and page describes that it's ok to map on structures and buildings. When this Bird Hide preset is assigned to an area in iD, we add a building=yes tag (which the user can change to something more specific, or choose to remove if it's not really a building).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

2 participants