Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically filled out hashtags shouldn't be cached #4304

Closed
tyrasd opened this issue Sep 1, 2017 · 1 comment
Closed

automatically filled out hashtags shouldn't be cached #4304

tyrasd opened this issue Sep 1, 2017 · 1 comment
Labels
bug A bug - let's fix this!

Comments

@tyrasd
Copy link
Member

tyrasd commented Sep 1, 2017

Here's what I see as potentially confusing: When a user loads iD from an external page that initializes the chanset comment with some text that includes some hashtags, these are also set in the new hashtags list (and hashtags field of the osm changeset). These hashtags are kept in the browser's cache just like manually entered hashtags. If a user is not aware about what hashtags are, they could continue to commit other changes with these hashtags, even though these hashtags likely don't apply anymore. A similar case is when a user opens jobs from multiple HOT tasking manager projects, without thinking about cleaning up the hashtags list when changing from one HOT project to another one. Here's an example, where the hashtags includes multiple #hotosm-project- ids, even though it obviously should only belong to one: http://www.openstreetmap.org/changeset/51495572

I think automatically parsed hashtags shouldn't be persisted/cached. Additionaly, if iD is opened with an external changeset-comment "template", and if that one includes any hashtags, the existing cached hashtags should probably be cleared (because it would be easy to overlook any existing hashtags that likely not fit the current task anymore in a longish list of automatically filled out list of hashtags).

@bhousel
Copy link
Member

bhousel commented Sep 7, 2017

I think automatically parsed hashtags shouldn't be persisted/cached. Additionaly, if iD is opened with an external changeset-comment "template", and if that one includes any hashtags, the existing cached hashtags should probably be cleared

I agree, this was something I wasn't too sure about when I implemented the feature - so I just made it work like the existing comments field - then added the automatic parsing later, which I realize now can conflict with the cached ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

2 participants