Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching server while loading causes glitchy behavior #4288

Closed
JamesKingdom opened this issue Aug 27, 2017 · 2 comments
Closed

Switching server while loading causes glitchy behavior #4288

JamesKingdom opened this issue Aug 27, 2017 · 2 comments
Labels
bug A bug - let's fix this!

Comments

@JamesKingdom
Copy link
Collaborator

ezgif com-optimize

Loading somewhere on the live server then switching to dev half way through causes the loaded data to remain and cause glitchy movement

@bhousel
Copy link
Member

bhousel commented Sep 7, 2017

Good find @JamesKingdom - we have to cancel those async callbacks when the connection changes. 😢

@bhousel bhousel added the bug A bug - let's fix this! label Sep 7, 2017
@bhousel
Copy link
Member

bhousel commented Nov 15, 2017

I added a bunch of code in 9b705a6 to avoid calling the OSM API callbacks after a connection reset or switch.

This mostly works, but there are still issues if you switch from "live" -> "dev" -> "live" very quickly.

This means there is still some state being stored somewhere and referenced from a deferred call. My suspicion is that this is in map.js. I think we need to add a proper Map.reset() method, to really throw out all the state and cancel all deferred work. But it's good enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

2 participants