Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chinese address format #4248

Merged
merged 1 commit into from Aug 19, 2017
Merged

Update Chinese address format #4248

merged 1 commit into from Aug 19, 2017

Conversation

ghost
Copy link

@ghost ghost commented Aug 19, 2017

We have addr:district that works similar as addr:unit (in western style).
In Chinese language, the word 'unit' is translated to "单元"(a numbered entrance of a building), which is more specific than addr:housenumber, so there's no need to keep it.

See https://en.wikipedia.org/wiki/Address_(geography)#China

#3980
#4235

@bhousel bhousel added the localization Adapting iD across languages, regions, and cultures label Aug 19, 2017
@JamesKingdom
Copy link
Collaborator

JamesKingdom commented Aug 19, 2017

Thanks for changing this, it looks like unit is only used a few times in China.
I have never seen a Chinese address, so it is nice to hear recommendations from somebody with experience.
Look good 👍

@JamesKingdom JamesKingdom merged commit ede87b1 into openstreetmap:master Aug 19, 2017
@althio althio mentioned this pull request Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Adapting iD across languages, regions, and cultures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants