Adding unit field to USA

[JamesKingdom]

Closes #3980

[bhousel]

This looks good - why only USA?

[bhousel]

You can just combine this with "ca" (Canada), they're the same

[bhousel]

Thanks @JamesKingdom this looks great 👍

[1ec5]

I don’t think we should include addr:unit in the Vietnam address format. There’s only one (mistaken) use of this tag in all of Vietnam, reflecting the fact that units aren’t numbered in that country. Floor numbers are sometimes given in addresses, but generally the smallest level of addressing is the building number.

Addresses can be quite granular even without addr:unit, because the addr:housenumber and addr:street tags are both hierarchical. For example, this is the address of building 8, alley 251, lane 48, Nguyễn Khang street:

Số 48/251/8 đường Nguyễn Khang
Xã Yên Hòa
Quận Cầu Giấy
Hà Nội

addr:housenumber=48/251/8
addr:street=Nguyễn Khang
addr:subdistrict=Yên Hòa
addr:district=Cầu Giấy
addr:city=Hà Nội

addr:housenumber can be even more complex, for example 7/14/12/3/23. On the other hand, some mappers prefer to put all the alley and lane numbers in addr:street so the map doesn’t look so cluttered, for example lane 19, Liễu Giai street.

More information about Vietnam’s address formats:

https://vi.wikipedia.org/wiki/Địa_chỉ
https://youbianku.com/files/upu/VNM.pdf
http://vforum.vn/diendan/showthread.php?91066-Thon-Xom-Ap-Xa-Phuong-Huyen-Quan-Tinh-Thanh-Pho-trong-tieng-Anh-la-gi-khi-viet-dia-chi-nha

/ref #2252

[JamesKingdom]

Alright, thanks for the information, I removed it in #4242

[speedbiker]

Is it possible to leave this "addr:unit"-field away in the German version, especially in Austria? It's useless for adresses in Austria and Germany.
And then more space on the monitor is available for addr:street-field.

[althio]

I think we should remove addr:unit in the fr address format. So PR #4667

But I must say... I think it was a bad move to add addr:unit by default and in all country formats.

[bhousel]

I think it was a bad move to add addr:unit by default and in all country formats.

Why?

[althio]

It is beneficial for US, CA, AU and doubtlessly other countries around the world (I guess Malaysia, HK...)

But some countries already had an address format in iD, why change them?
The rollbacks show that it was wrong for:

• VN
• CN
• BR
• AT, CH, DE
• PL
• FR, LU, MO
• ping @rory for IE
• ping @david082321 for TW
• ping @mertemin for TR
• ping @Andygol for UA
• ping @boothym for GB
  I have my doubts about NO and a few others.

I have my own bias about why addr:unit should not be in a standard default address format worldwide.
I feel it is suitable for some countries with dense cities and HIGH towers. It makes little sense worldwide, if I must guess.

[speedbiker]

For HU and SI I also do not see any benefit.

[amandasaurus]

I don't think addr:unit should be a default for IE.

I read the wiki page for addr:unit and I'm still confused. We don't tend to have "multiple separate entrances". Irish addresses are all over the place, so it's not uncommon for it to be unclear where things are.

"Unit" is very rarely used in Irish addresses, mostly for separate addresses within a (light) industrial estate. So you might see "Mappy Ltd., Unit 5, Whatever Road, Ballytown Industrial Estate, Co. Whatever". Here "Unit" is addr:housenumber, and different from addr:unit. I'm unsure if there is >100 addresses in Ireland that would use addr:unit.

[mertemin]

addr:unit is not needed for Turkish either.

[bhousel]

Please submit PRs so that the address field looks however you want it to look.