Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging two objects as first edit does not activate the undo button #4113

Closed
ToeBee opened this issue Jun 21, 2017 · 3 comments
Closed

Merging two objects as first edit does not activate the undo button #4113

ToeBee opened this issue Jun 21, 2017 · 3 comments
Labels
bug A bug - let's fix this!

Comments

@ToeBee
Copy link
Contributor

ToeBee commented Jun 21, 2017

If as your first action you choose a building outline and a point within it and use the "Merge" feature, the undo button is not properly activated. It is still grayed out and the hover text says "Nothing to undo". However if you click it, it does actually still work and undoes the merge.

I can reproduce this on both Chromium 58 and Firefox 54.

@bhousel bhousel added the bug A bug - let's fix this! label Jun 21, 2017
@bhousel
Copy link
Member

bhousel commented Jun 21, 2017

Thanks - that does sound like a bug..

@ToeBee
Copy link
Contributor Author

ToeBee commented Jun 21, 2017

Additionally, if you do a merge and then do something else (for example, drop a new point feature) and then use the undo button, the merge will be silently undone when you undo that last action.

So:

  1. Merge a way and a node
  2. Create a new point feature
  3. Undo point creation
  4. Point creation is undone but so is the merge

@bhousel
Copy link
Member

bhousel commented Jun 21, 2017

Ah yeah that makes sense.. We recently added an extra step to re-match the preset for the newly merged object (in order to cleanup unneeded tags like area=yes - see #3851). It was that extra step that was messing up the undo/redo annotation.

Thanks for reporting this @ToeBee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

2 participants