Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribution: Change problem, color #4047

Closed
AllroadsNL opened this issue May 16, 2017 · 4 comments
Closed

Attribution: Change problem, color #4047

AllroadsNL opened this issue May 16, 2017 · 4 comments
Labels
usability An issue with ease-of-use or design

Comments

@AllroadsNL
Copy link

Attribution change;

link tweak

How much time does it take to the new attribution setting.
After 3 days nothing changed on the screen.

attributtion
attributtion2

@bhousel
Copy link
Member

bhousel commented May 16, 2017

The attribution will be updated the next time I make a release of iD. Releases normally happen once or twice a month.

I'll see if I can improve the attribution text color - I agree it's not very readable.

@bhousel bhousel added the usability An issue with ease-of-use or design label May 16, 2017
@bhousel
Copy link
Member

bhousel commented Jun 16, 2017

I spent some time improving the visibility of the attribution today. I tried a bunch of tricks like CSS text-shadow and mix-blend-mode to get the text to stand out from the background better, but nothing really worked great. This is because the attribution text is pretty small, and we want to keep it that way.

After all that, I ended up just brightening the color a little bit. You can try it out on http://preview.ideditor.com/master/ - let me know what you think. There will always be some background colors that make it almost impossible to read the text, but hopefully it is more visible now on the kinds of colors that we typically see in background imagery.

I also added icons for the layers that support them, and refreshed a few of the sources that have new logos.

@althio
Copy link
Contributor

althio commented Jun 17, 2017

Maybe you can move the content of this block id="attrib"(?) in the block id="footer" or use a similar style with a dark transparent background?

@bhousel
Copy link
Member

bhousel commented Jun 18, 2017

Maybe you can move the content of this block id="attrib"(?) in the block id="footer" or use a similar style with a dark transparent background?

I'm pretty happy with it as is. I don't want the text to stand out too much, and I don't want it to take up the entire row, stealing the mouse events and reducing the amount of screen space where users can edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

3 participants