Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-selecting line tool removes current line that is being drawn #4042

Closed
simonpoole opened this issue May 14, 2017 · 1 comment
Closed

Re-selecting line tool removes current line that is being drawn #4042

simonpoole opened this issue May 14, 2017 · 1 comment
Labels
usability An issue with ease-of-use or design

Comments

@simonpoole
Copy link
Contributor

simonpoole commented May 14, 2017

Not clear if this is intended behaviour, I would suggest doing nothing or completing the current line drawing and re-entering line drawing mode.

See https://help.openstreetmap.org/questions/56174/can-not-add-line-with-id-editor

@bhousel
Copy link
Member

bhousel commented May 14, 2017

Yes, I agree we shouldn't remove the user's line.. That's a recent regression caused by these lines of code. The code is actually useful because it lets us support undo while the user draws (#3530) at the expense of throwing away all the user's work whenever something unexpected happens.

I think I can find a way to handle leaving and reentering the same mode cleanly.

@bhousel bhousel added the usability An issue with ease-of-use or design label May 14, 2017
@bhousel bhousel closed this as completed in d0fcae1 Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

2 participants