-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make background imagery names translatable #4034
Comments
Oh we actually have an issue for this in editor-layer-index: osmlab/editor-layer-index#17 I'm not sure the best way to do it. I could see it either being localized in that project, or in iD. Maybe I should just add it as another resource to the id-editor team on transifex for the imagery list. Then we wouldn't need to ask people to sign up for another project. |
@bhousel |
Yes, but they all come from the imagery list, the overlay sources just have checkboxes instead of radio buttons. |
There is a PR in editor-layer-index to solve that problem osmlab/editor-layer-index#343 |
The upstream work was done and we now have a new imagery resource attached to the iD project. Next steps are for me to merge this resource into iD's language files and use |
I can translate the layer names in transifex-ideditor-imagery and see the effect on preview.ideditor.com/master Thanks! |
Great, I just also added support to display translated attribution text too, so closing here 👍 |
Are these items from iD or do i have to translate somewhere else?
The text was updated successfully, but these errors were encountered: