Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walkthrough panning still problematic #3969

Closed
ghost opened this issue Apr 14, 2017 · 2 comments
Closed

Walkthrough panning still problematic #3969

ghost opened this issue Apr 14, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 14, 2017

@bhousel Great that you've worked on the walkthrough!

I'm afraid #2386 isn't yet fixed though.

panning

Screencast of latest Firefox on Linux, 52.0.2. I had the same with Brave (which is based on Chromium).

Somtimes even the shrinkwrapping effect misses the City Hall, and focuses on another place. That happens quite often, but strangely never while I'm making a screencast*.

Other stages of the walkthrough also have this issue.


*This is not an attempt to be funny, I literally mean this.
I tried 20+ times to reproduce it while screencasting, but never succeeded.
Without screencasting, window at same size: 4/10 times glitched.
Procedure: start walkthrough from welcome screen, pan, observe effect, Ctrl+R, repeat.

@bhousel
Copy link
Member

bhousel commented Apr 14, 2017

I can see from the screenshot that you're still testing with the old walkthrough code. The new walkthrough is on #3921, which has not merged to master yet.

You can test the code on that branch by using the Runnable link (see first comment on that PR):
test link: http://265ykk-id-runnable-staging-openstreetmap.runnableapp.com:8080/

Please let me know if that works for you, and put your comments on #3921, thanks! Hoping to merge in the next day or so..

@ghost
Copy link
Author

ghost commented Apr 14, 2017

Great! I saw the PR in the list but totally forgot that green=open, purple=merged, I always found that very confusing on GitHub. Sorry for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant