Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix text padding in key-value input field #3894

Merged
merged 5 commits into from
Mar 22, 2017

Conversation

51114u9
Copy link
Contributor

@51114u9 51114u9 commented Mar 13, 2017

When you input/retrive long texts in the ket-value box, the combobox caret hide the end of it

captura de pantalla - 130317 - 01 15 49

@bhousel
Copy link
Member

bhousel commented Mar 13, 2017

Looks pretty good to me. Can you check this also with &rtl=true in the url, just to make sure it looks ok right-to-left.

@51114u9
Copy link
Contributor Author

51114u9 commented Mar 13, 2017

@bhousel no, I will check.

@51114u9
Copy link
Contributor Author

51114u9 commented Mar 13, 2017

@bhousel ok, now right-to-left looks good.

@bhousel
Copy link
Member

bhousel commented Mar 15, 2017

Can you double check the css rules? Now it looks like all the fields have extra padding..
(I'm in LTR right now):

screenshot 2017-03-15 16 18 53

@51114u9
Copy link
Contributor Author

51114u9 commented Mar 16, 2017

my error, but I fixed. I tested with two directions and looks good.

@bhousel bhousel merged commit ea71929 into openstreetmap:master Mar 22, 2017
@bhousel
Copy link
Member

bhousel commented Mar 22, 2017

Thank you @51114u9! I just merged it 👍

@51114u9 51114u9 deleted the input-text-style branch March 22, 2017 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants