Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combos don't always get placeholders from taginfo #3874

Closed
bhousel opened this issue Mar 3, 2017 · 1 comment
Closed

Combos don't always get placeholders from taginfo #3874

bhousel opened this issue Mar 3, 2017 · 1 comment
Labels
bug A bug - let's fix this!

Comments

@bhousel
Copy link
Member

bhousel commented Mar 3, 2017

When you hover over an item, combo fields are created, and taginfo calls fire off to fetch the placeholders for those fields. But it seems like if you select the item by clicking on it before the callback is called, the field never gets a placeholder.

screenshot 2017-03-02 21 07 53

@bhousel bhousel added the bug A bug - let's fix this! label Mar 3, 2017
@bhousel
Copy link
Member Author

bhousel commented Mar 3, 2017

Oh, it's probably because the requests are debounced
https://github.com/openstreetmap/iD/blob/master/modules/services/taginfo.js#L139

@bhousel bhousel closed this as completed in cd23d76 Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

1 participant