Add kml and geojson support to gpx layer #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertemin
changed the title
mertemin
changed the title
|
Awesome! Yes this is what I had in mind 👍 I'll try it out tonight or tomorrow... |
|
Works perfectly! Just merged, thanks again! |
tyrasd
reviewed
Feb 6, 2017
| @@ -139,7 +166,8 @@ export function svgGpx(projection, context, dispatch) { | |||
| drawGpx.url = function(url) { | |||
| d3.text(url, function(err, data) { | |||
| if (!err) { | |||
| drawGpx.geojson(toGeoJSON.gpx(toDom(data))); | |||
| var extension = getExtension(url); | |||
There was a problem hiding this comment.
FYI: this caused #3820 since url is just a string and getExtension() expects a File object. I fixed it by changing getExtension() to expect a string instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After @bhousel's comment on #3808 I updated existing gpx layer, added ability to read in .kml and .geojson files based on file extension.