Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iD freezes when opening this place #3737

Closed
tadanet3 opened this issue Jan 9, 2017 · 9 comments
Closed

iD freezes when opening this place #3737

tadanet3 opened this issue Jan 9, 2017 · 9 comments
Labels
bug A bug - let's fix this!

Comments

@tadanet3
Copy link

tadanet3 commented Jan 9, 2017

Hi,

Browser freezes when opening this place.
https://www.openstreetmap.org/#map=17/34.69410/135.38259

I'm using Ubuntu16.10+Firefox.

@edpop
Copy link
Contributor

edpop commented Jan 9, 2017

+1 Windows 7, Chrome 55

@manfredbrandl
Copy link
Contributor

also freezes for Chromium Version 55.0.2883.75 Built on 8.6, running on Debian 8.6 (64-bit)

@kepta
Copy link
Collaborator

kepta commented Jan 10, 2017

I was able to reproduce this as well on Chrome 55.0.2883.95 (64-bit), running on Mac OS 10.12.2.

@kepta kepta added the bug A bug - let's fix this! label Jan 10, 2017
@edpop
Copy link
Contributor

edpop commented Jan 10, 2017

That is because of http://www.openstreetmap.org/relation/6677259 (25085 members). Try to edit over any boundary of Japan.

@kepta kepta removed the bug A bug - let's fix this! label Jan 10, 2017
@kepta
Copy link
Collaborator

kepta commented Jan 10, 2017

@edpop while I agree with you that there are 25085 members.
The problem is that I get different performances from way 131022503 (very slow) and way 131019312 (reasonable), both being in the same relation 6677259

It seems to slow down with 25085 members.

@bhousel bhousel added the bug A bug - let's fix this! label Jan 10, 2017
@bhousel
Copy link
Member

bhousel commented Jan 10, 2017

Some discussion of this on #1201

@pnorman
Copy link
Contributor

pnorman commented Jan 13, 2017

The relation is 1.2 MB and downloads in <1s on a fast connection. The relation/full is 102MB and 3m to download, but that's not currently used so not relevant for this bug. My guess is something in iD scaling badly on the relations member list and some operation is O(n^too much).

I think there's a data modeling error in the OSM data too, but it still shouldn't crash iD, just take longer for the /map call.

@bhousel
Copy link
Member

bhousel commented Jan 13, 2017

My guess is something in iD scaling badly on the relations member list and some operation is O(n^too much).

Agree w this.. It could be in the sidebar code that lists the relation members, or the code that attempts to class them with select halos, or the feature classifier/filters, other any number of other things. It wouldn't surprise me if there are plenty of places in iD that are just not designed to handle a relation with 25k members.

@07pepa
Copy link

07pepa commented Feb 1, 2017

Vivaldi 1.6.689.4 not afected! 👍

@bhousel bhousel added the priority A top priority issue that has a big impact or matter most to new mappers label Mar 29, 2017
@bhousel bhousel removed the priority A top priority issue that has a big impact or matter most to new mappers label Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

7 participants