Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radial Menu is full #3671

Closed
bhousel opened this issue Dec 22, 2016 · 7 comments · Fixed by #3753
Closed

Radial Menu is full #3671

bhousel opened this issue Dec 22, 2016 · 7 comments · Fixed by #3753
Assignees
Labels
usability An issue with ease-of-use or design

Comments

@bhousel
Copy link
Member

bhousel commented Dec 22, 2016

For closed ways, the radial menu is full.

The addition of the Reflect commands pushes the menu to 8 items, which is really too many.

The radial menu was already problematic, and it's something we've put off dealing with, but now we really should do something about it.

ccing @samanpwbb for advice

Not looking to bikeshed, but in absence of concrete suggestions or help, I'll probably just change it to be a wider circle, or a fixed menu someplace.

screenshot 2016-12-22 16 06 38

Also tooltip placement on the left side of the menu is broken:
screenshot 2016-12-22 16 19 57

prior discussion
#2145
#1994
#548
#226

@bhousel bhousel added the usability An issue with ease-of-use or design label Dec 22, 2016
@bhousel
Copy link
Member Author

bhousel commented Dec 22, 2016

one option

screenshot 2016-12-22 16 40 03

@samanpwbb
Copy link
Member

samanpwbb commented Dec 22, 2016

I think we should opt for a more conventional menu, with visible text labels:

screen shot 2016-12-22 at 5 05 40 pm

I also suggest that we show this menu on right click, which solves the problem of this thing being obtrusive while you're trying to select / move / edit features.

I would recommend against moving the menu to a set position, since many of the actions depend on cursor position.

@bhousel
Copy link
Member Author

bhousel commented Dec 22, 2016

Cool @samanpwbb I like it..

@bgirardot
Copy link

@samanpwbb I like it too, much easier for new mappers to understand and discover functionality.

@bhousel bhousel added the wip Work in progress label Jan 12, 2017
@kepta
Copy link
Collaborator

kepta commented Jan 13, 2017

I tried to work on this issue. The context menu looks good. Here is the demo:

2017-01-13 11_06_25

@samanpwbb As you can see the tooltip is bit of a problem. Personally I don't think I have ever seen a tooltip for right click menus. What do you think ?

@bhousel
Copy link
Member Author

bhousel commented Jan 13, 2017

This is awesome @kepta!
I think the tooltip is ok, but defer to @samanpwbb's opinion.

My thinking on the tooltip is - even if it's not perfect, it's better than before where tooltips could show up really anywhere around the radial menu and even on top of it.

screenshot 2017-01-13 11 13 57

@slhh
Copy link
Contributor

slhh commented Jan 14, 2017

@kepta The visual impression doesn't really associate the tooltip to a specific menu item. If the hover styling of the menu item were more visible, this would likely become clear. Maybe the hover styling of the item should include the text label area too.

@bhousel bhousel removed the wip Work in progress label May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants